[Frontend] - #388 - replace sessionStorage by localStorage - #389
Merged
Conversation
brentjan
requested changes
Apr 3, 2025
brentjan
left a comment
brentjan
left a comment
Contributor
There was a problem hiding this comment.
Does work now by opening the site in multiple tabs? Maybe we can also implement the logic of first checking the local storage and try to log in with that first (and redirect if succesful).
Contributor
Author
|
@brentjan and I manually confirmed this, since testing this is quite complicated. This works as expected and should not pose any issues. |
brentjan
approved these changes
Apr 3, 2025
rvdkeere
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Description
Because of the different scope of
localStoragevssessionStorage, @brentjan thought it would be a good idea to switch to the first.This PR simply does that and nothing more