[Frontend] - Login & Register Pages - #340
Merged
Merged
Conversation
Merge Development with main for release Milestone 1
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) to 7.26.10 and updates ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These dependencies need to be updated together. Updates `@babel/runtime` from 7.24.0 to 7.26.10 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime) Updates `@angular-devkit/build-angular` from 17.3.12 to 17.3.13 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@17.3.12...17.3.13) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-type: indirect - dependency-name: "@angular-devkit/build-angular" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…/multi-65d1bb503c chore(deps): bump @babel/runtime and @angular-devkit/build-angular in /frontend
This was
linked to
issues
Mar 23, 2025
Closed
… the components succeed
This was
unlinked from
issues
Mar 23, 2025
Closed
bramcomyn
marked this pull request as ready for review
March 24, 2025 09:24
brentjan
approved these changes
Mar 24, 2025
brentjan
left a comment
brentjan
left a comment
Contributor
There was a problem hiding this comment.
Still need the rest of the field of register and also the actual call to the backend but looks ok!
This was
linked to
issues
Mar 24, 2025
Closed
This was
unlinked from
issues
Mar 24, 2025
Closed
Contributor
|
Now we have a checkbox on the register page that captures whether the user is a student or a teacher. Wouldn't it be better if it is a dropdown with the 2 options: Teacher or Student? |
Contributor
Author
|
That is a great idea, I can make that happen if you want to. |
rvdkeere
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added the login and register pages. These are functional, but do not yet redirect the user to the desired pages (as these are still missing!).
Related Issues
Notes