[Backend] - 316 repository interfaces refactor - #339
Merged
Conversation
…ord Assignment. Im going to do this for all the repository interfaces so that they are ready to inherit from a general repository interface
…. This is now consistent for all repositories
brieromb
requested review from
Adrien-VL,
LambrechtMaarten and
thomasdejaeghere
March 23, 2025 08:49
brentjan
changed the title
Contributor
Author
|
btw the tests only fail because of the linter, how can I fix these pretty-issues? |
Contributor
Author
|
@Adrien-VL is it okay that this is merged first, and then I make another branch from development to edit the submission repository like you asked in discord? |
thomasdejaeghere
approved these changes
Mar 26, 2025
Adrien-VL
force-pushed
the
316-repository-interfaces-refactor
branch
from
March 29, 2025 14:30
0897b44 to
dee7c6d
Compare
…-interfaces-refactor
Adrien-VL
approved these changes
Mar 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only change that was really made is the naming of the methods in the repository interfaces.
They are now more consistent and can be inherited more easily.
I changed the method names so that they can more easily be inherited. For example I changed
studentRepository.createStudent(...)tostudentRepository.create(...)So that repositories could inherit thecreatemethod.Also there was a mix of
deleteByIdanddeletemethods, which are actually the same. I changed all thedeleteByIdtodeletefor consistency.