198 backend core services every class service - #202
Merged
thomasdejaeghere merged 15 commits intoMar 11, 2025
Merged
Conversation
- getUserClass is implemented in getClass - setupClass is createClass - invite...ToClass will be implemented in joinRequests
LambrechtMaarten
left a comment
LambrechtMaarten
left a comment
Contributor
There was a problem hiding this comment.
Good use of the Optional!
…o 198-backend---core---services---every-class-service
LambrechtMaarten
self-requested a review
March 11, 2025 13:46
LambrechtMaarten
approved these changes
Mar 11, 2025
thomasdejaeghere
approved these changes
Mar 11, 2025
thomasdejaeghere
deleted the
198-backend---core---services---every-class-service
branch
March 11, 2025 13:58
1 task
1 task
This was
linked to
issues
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented:
And tests for every case.
What else:
Why are tests failing?
Upon agreed changes to
services.ts(with @thomasdejaeghere and @LambrechtMaarten), files and tests out of the scope of this branch need to changeService<T extends ServiceParams, ReturnType>toService<T extends ServiceParams>.The tests for this branch have all passed.
This closes:
deleteClassImplementation #92getClassImplementation #93createClassImplementation #99updateClassImplementation #100