Feat: Implementation of use-case for removing a student from a group - #159
Merged
thomasdejaeghere merged 6 commits intoMar 9, 2025
Conversation
…mgroup---implementation
…ation' into 158-backend---core---removestudentfromgroup---implementation
…and class removal + implementation of new use-case flow for class removal
| async execute(input: RemoveStudentFromParams): Promise<object> { | ||
| const id: RemoveStudentID = input.fromObject(); | ||
| await this.removeStudent(id.studentId, id.otherId); | ||
| return {}; |
Contributor
There was a problem hiding this comment.
In delete student I implemented a check if the student that needs to be deleted exist or not by getting the student from the database before deleting it. Is this something that can be added here as well or is it not necessary? (@brentjan if you could give your opinion too please ;) )
Contributor
There was a problem hiding this comment.
This shouldn't be necessary since in the datasource i already check if a (in my case) teacher exists. @brieromb should also have done this for the student datasource.
thomasdejaeghere
approved these changes
Mar 9, 2025
1 task
brentjan
approved these changes
Mar 9, 2025
Contributor
|
I made a new issue (#176) that will implement the new method in the repository! |
…mgroup---implementation
thomasdejaeghere
deleted the
158-backend---core---removestudentfromgroup---implementation
branch
March 9, 2025 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removeStudentFromGrouptoStudentRepositoryInterface