132 backend application rename thread question - #135
Merged
bramcomyn merged 33 commits intoMar 5, 2025
Merged
Conversation
…hub.com/SELab-2/Dwengo-2 into 26-38-47-backend-application-assignment
…d-application-class-routes-implementation
refactor: renamed backend/src/application/helpers.ts to helpersExpress.ts
…e-thread-question
…ub.com:SELab-2/Dwengo-2 into 132-backend-application-rename-thread-question
Adrien-VL
reviewed
Mar 3, 2025
Adrien-VL
reviewed
Mar 3, 2025
Contributor
There was a problem hiding this comment.
@bramcomyn, although most the problems that the comments mentioned can be considered optional and can be resolved after merge it would be nice to tackle them before the resolution of this PR.
Contributor
Author
|
You're absolutely right! |
…ssages and pending invites
…ns of some controllers ; updated index.ts
Contributor
Author
|
I will also split out the tests for routers, as this will make them less prone to errors or complex typing issues. |
thomasdejaeghere
deleted the
132-backend-application-rename-thread-question
branch
March 11, 2025 22:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As requested in our last meeting, I added to our API's specification the routes for retrieving messages in question threads. Besides that, I checked the names of the routes and made sure all route names are pluralized, as is recommended when writing a RESTful API.
Changes
/questions/:idParent/messages/:idand/questions/:idParent/messages