Skip to content

Fix the potential leak of chunk iterator used for ICC Profile colorSpace check #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2019
Merged

Fix the potential leak of chunk iterator used for ICC Profile colorSpace check #5

merged 1 commit into from
Jan 22, 2019

Conversation

@dreampiggy
Copy link
Contributor

@dreampiggy dreampiggy commented Jan 22, 2019

This fix the potential leak of WebPChunkIterator. The libwebp says:

// Call WebPDemuxReleaseChunkIterator() when use of the iterator is complete.

This also imporve the performance by checking the ICC flags before actual grab the chunk.

@dreampiggy
Copy link
Contributor Author

dreampiggy commented Jan 22, 2019

CC: SDWebImage/SDWebImage#2596

@dreampiggy dreampiggy merged commit 94bec17 into master Jan 22, 2019
@bpoplauschi bpoplauschi deleted the bugfix_iccp_leak branch January 24, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dreampiggy