fix: removed usage of deprecated tf2 C header #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more like a FYI:
In version 0.42.1 of tf2 the support for the deprecated C style headers like
tf2/LinearMath/Quaternion.hwas removed. Thus this driver could not be compiled using ROS2 rolling since its on 0.45.1-1 right now. I updated the includes.This will probably break backwards compatibility since e.g. ros2 humble is still on version 0.25.17-1 of tf2. The C++ style headers were only introduced in version 0.40.0.