fix(preview-middleware): fix /cards/store endpoint for CAP projects#4243
Merged
Singham-24 merged 6 commits intomainfrom Feb 27, 2026
Merged
fix(preview-middleware): fix /cards/store endpoint for CAP projects#4243Singham-24 merged 6 commits intomainfrom
Singham-24 merged 6 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 1425e0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Singham-24
force-pushed
the
fix/preview-middleware/cap-cards-store-endpoint
branch
from
ee6e479 to
c395e50
Compare
Singham-24
force-pushed
the
fix/preview-middleware/cap-cards-store-endpoint
branch
from
da4e5db to
6605036
Compare
heimwege
approved these changes
Feb 27, 2026
Contributor
heimwege
left a comment
heimwege
left a comment
There was a problem hiding this comment.
- review comments addressed
- changes are straightforward
- coverage is excellent
- changeset ok
- did NOT test manually
Sharmavksh
approved these changes
Feb 27, 2026
Contributor
Sharmavksh
left a comment
Sharmavksh
left a comment
There was a problem hiding this comment.
code change are simple / straightforward with good code coverage.
Looks good to me.
|
Singham-24
deleted the
fix/preview-middleware/cap-cards-store-endpoint
branch
devinea
added a commit
that referenced
this pull request
Feb 27, 2026
* origin/main: fix(infra): upgrade fast-xml-parser (#4268) chore: apply latest changesets fix(ui-service-inq): use hidenewsystem prompt option for ui service generator (#4258) fix(infra): basic-ftp (#4259) Improve package validation message for with lowercase warning (#4248) Increase timeout for workflow to 60 minutes fix(docs): update README with .mjs configuration examples (#4253) chore: apply latest changesets fix(preview-middleware): fix /cards/store endpoint for CAP projects (#4243)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix /cards/store and /editor/i18n endpoints for CAP projects. In CAP projects,
path.resolve()returns the CAP root instead of the UI5 app directory. The fix usesgetSourcePath()for CAP projects which returns the correct webapp path.