docs: update title and meta information on page change #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbadan
commented
Mar 19, 2019
| "react-dev-utils": "^6.1.1", | ||
| "react-dom": "^16.6.3", | ||
| "react-element-to-jsx-string": "^14.0.2", | ||
| "react-helmet-async": "^0.2.0", |
Contributor
Author
There was a problem hiding this comment.
@greg-a-smith does this need to be in regular dependencies or is dev deps ok?
Contributor
There was a problem hiding this comment.
Seems like it could just live in dev dependencies.
greg-a-smith
suggested changes
Mar 20, 2019
| "react-dev-utils": "^6.1.1", | ||
| "react-dom": "^16.6.3", | ||
| "react-element-to-jsx-string": "^14.0.2", | ||
| "react-helmet-async": "^0.2.0", |
Contributor
There was a problem hiding this comment.
Seems like it could just live in dev dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using react-helmet-async, we can update the title and meta description in the head to be accurate on page change. I put the SetMeta component inside utils for now, but am open to moving it to it's own folder.
Also fixes the logo routing issue.
fixes #456 #468