fix: CORUI-6264: One component per file Menu #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/index.js
Outdated
| export { default as Menu } from './Menu/Menu'; | ||
| export { default as MenuList } from './Menu/MenuList'; | ||
| export { default as MenuItem } from './Menu/MenuItem'; | ||
| export { default as MenuGroup } from './Menu/MenuGroup'; |
Contributor
There was a problem hiding this comment.
I would have expected to see all these as static references on Menu and then only Menu would be exported. Something like:
Menu.Item = MenuItem;
Menu.Group = MenuGroup;
Menu.List = MenuList;
Contributor
Author
There was a problem hiding this comment.
I agree, should've caught that. Moved to subcomponents in 8127fcc
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* Rename file * Rename temp * Restore original * Rename file * Rename temp * Restore original * Rename file * Rename temp * Restore original * Separate components * Move Menu subcomponents * Update snapshot with correct on click function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Menudirectory into their own files.