feat: Remove React Router from Menu #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbadan
reviewed
Jan 25, 2019
jbadan
reviewed
Jan 25, 2019
src/Menu/Menu.js
Outdated
|
|
||
| // ---------------------------------------- Menu Item ---------------------------------------- | ||
| export const MenuItem = ({ url, link, isLink, separator, addon, children, onclick, className, addonProps, linkProps, urlProps, ...props }) => { | ||
| export const MenuItem = ({ url, link, isLink, separator, addon, children, onclick, className, addonProps, urlProps, ...props }) => { |
Contributor
There was a problem hiding this comment.
The link prop type was removed so can it be removed from here as well?
greg-a-smith
approved these changes
Jan 28, 2019
Contributor
greg-a-smith
left a comment
greg-a-smith
left a comment
There was a problem hiding this comment.
Assuming the build passes, this looks good. 🚢
Contributor
Author
|
Fixed the issue with the build. Simply had to make sure when spreading our |
This was referenced Jan 31, 2019
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* Saving state * Updating menu to factor out react-router * Update linting * Reverting breadcrumb for easier Menu PR * Updating Menu Component Documentation * Remove unneeded MemoryRouter component from test * Removing stray prop * Second commit * Second commit * Updating Menu PR to spread Classnames * Updating description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to remove the dependency on React Router from Fundamentals-React (#115), we must refactor the the following components...
This PR is focused on Menu and does introduce breaking changes such as...
React Router Menu Example (NEW)
Anchor via children (NEW)
Anchor via Props (Classic)