feat: 1020: Shellbar pass popoverProps to SearchInput #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ fix: productSwitch aria-label and its documentation + fix: popover props doc markdown
|
Deploy preview for fundamental-react ready! Built with commit cc344d1 |
jbadan
reviewed
Jun 12, 2020
| //to always show search-results popup towards bottom | ||
| disableEdgeDetection: true, | ||
| placement: 'bottom' | ||
| } |
Contributor
There was a problem hiding this comment.
Should we add these as defaults (in shellbar only - not searchinput in general) for consumers that they can then override if they want to?
jbadan
reviewed
Jun 12, 2020
| /** For navigating between products. An object that contains an accessible label for product switch button. */ | ||
| productSwitch: PropTypes.shape({ | ||
| /** Accessible label for product switch button */ | ||
| label: PropTypes.string.isRequired |
Contributor
There was a problem hiding this comment.
👏 Should we mark this as a breaking change when merging since this is now required?
prsdthkr
changed the title
jbadan
approved these changes
Jun 12, 2020
Contributor
jbadan
left a comment
jbadan
left a comment
There was a problem hiding this comment.
LGTM 🚢 I know we have the issue going on with the snapshots but I think it's fine to merge this then fix the bug separately. It's up to you though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change
placement='bottom'anddisableEdgeDetection=trueproductSwitch.labelproductSwitch.labelprop is now requiredproductSwitch.labelprop documentedwidthSizingTypeprop documentation markdown is fixed. Earlier, using MD codefixes #1020