Skip to content

Commit 6b2c241

Browse files
authored
fix: gh-pages deployment process (#307)
* set gh pages build to development * disable error catching
1 parent 54f7041 commit 6b2c241

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

config/webpack.config.prod.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ const env = getClientEnvironment(publicUrl);
4343

4444
// Assert this just to be safe.
4545
// Development builds of React are slow and not intended for production.
46-
if (env.stringified['process.env'].NODE_ENV !== '"production"') {
47-
throw new Error('Production builds must have NODE_ENV=production.');
48-
}
46+
// if (env.stringified['process.env'].NODE_ENV !== '"production"') {
47+
// throw new Error('Production builds must have NODE_ENV=production.');
48+
// }
4949

5050
// Check if TypeScript is setup
5151
const useTypeScript = fs.existsSync(paths.appTsConfig);

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,14 @@
3333
"watch-css": "npm run build-css && node-sass-chokidar --include-path ./src --include-path ./node_modules src/ -o src/ --watch --recursive"
3434
},
3535
"dependencies": {
36-
"annotated-prop-types": "^0.3.0",
3736
"classnames": "^2.2.6",
3837
"fiori-fundamentals": "^1.4.0",
3938
"react-router": "^4.3.1",
4039
"react-router-dom": "^4.3.1",
4140
"react-syntax-highlighter": "^9.0.1"
4241
},
4342
"devDependencies": {
43+
"annotated-prop-types": "^0.3.0",
4444
"@babel/cli": "^7.1.5",
4545
"@babel/core": "7.1.0",
4646
"@babel/polyfill": "^7.1.5",

scripts/build.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
'use strict';
22

33
// Do this as the first thing so that any code reading it knows the right env.
4-
process.env.BABEL_ENV = 'production';
5-
process.env.NODE_ENV = 'production';
4+
process.env.BABEL_ENV = 'development';
5+
process.env.NODE_ENV = 'development';
66

77
// Makes the script crash on unhandled rejections instead of silently
88
// ignoring them. In the future, promise rejections that are not handled will

0 commit comments

Comments
 (0)