Add type ExpandMsg to VoprfParameters#1814
Merged
Merged
Conversation
f5880f8 to
32af34a
Compare
tarcieri
approved these changes
May 19, 2025
tarcieri
pushed a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
May 21, 2025
Companion PR to RustCrypto/traits#1814
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main motivation was that
decaf448(RustCrypto/elliptic-curves#1121) requiresExpandMsgXofinstead ofExpandMsgXmd.I was briefly tempted to add a
type Hashto theExpandMsgtrait to be able to writetype ExpandMsg: ExpandMsg<Hash = Self::Hash>. Otherwise it is possible to add a different hash in theExpandMsgtype:But I thought its a bit much. Let me know if you want me to add that.