password-hash: Fix invalid operator in the SaltString struct constructor #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the length of `s` to be exactly the same amount as `MAX_LENGTH` value.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not 100% sure, but I think the length of provided string
sshould be lower or equal to theMAX_LENGTH.When implementing some algorithm that required 64 bytes long salt I couldn't make a new
SaltStringstructure due to this issue and simple change from<to the<=operator fixed it. What is more, functionSalt::newallows for thesstring to be exactly 64 bytes (MAX_LENGTH) long.I did not find any opened or closed issues related to this matter, so that's why I am not sure if it is a bug or a feature.