elliptic-curve: have serde feature activate pkcs8
#1245
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `Serialize`/`Deserialize` impls for `PublicKey` were gated on both the `pkcs8` and `serde` features being enabled, which is potentially confusing. `PublicKey` uses `pkcs8` to serialize the public key as SPKI, which includes OIDs which identify it as an elliptic curve public key and also another OID which identifies the curve. Now that features are namespaced, it's easy to activate `pkcs8` from the `serde` feature to make this a bit easier.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
Serialize/Deserializeimpls forPublicKeywere gated on both thepkcs8andserdefeatures being enabled, which is potentially confusing.PublicKeyusespkcs8to serialize the public key as SPKI, which includes OIDs which identify it as an elliptic curve public key and also another OID which identifies the curve.Now that features are namespaced, it's easy to activate
pkcs8from theserdefeature to make this a bit easier.