-
Notifications
You must be signed in to change notification settings - Fork 228
password-hash: add Error::OutputSize
#1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
password-hash: add Error::OutputSize
#1026
Conversation
password_hash::Error::OutputSizeError::OutputSize
cf55a17 to
c1f7018
Compare
|
This is back to having three different variants that effectively mean different flavors of the same thing. What about this instead? OutputSize { expected: Ordering, size: usize } |
3387d43 to
c80afb1
Compare
I wasn't sure how you mean that, I kinda turned it around, the Also squashed the commits. EDIT: I hope the documentation is sufficient and alright. |
7808718 to
ea87046
Compare
ea87046 to
a396237
Compare
tarcieri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now.
It's a breaking change though, so I might keep this open until we're ready to start working on the next version of password-hash.
|
@tarcieri just saw the new update to 0.5.0-pre.0, are we ready to add this breaking change now? |
Co-authored-by: Tony Arcieri <[email protected]>
70af450 to
91e2049
Compare
|
Thanks! |
See RustCrypto/password-hashes#313.
Sometimes a very specific output size is expected. Any bike-shedding is very welcome.