Skip to content

ecdsa: make fmt impls more consistent #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Apr 14, 2023
Merged

ecdsa: make fmt impls more consistent #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 17 additions & 20 deletions ecdsa/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,7 @@ pub use crate::signing::SigningKey;
#[cfg(feature = "verifying")]
pub use crate::verifying::VerifyingKey;

use core::{
fmt::{self, Debug},
ops::Add,
};
use core::{fmt, ops::Add};
use elliptic_curve::{
generic_array::{sequence::Concat, typenum::Unsigned, ArrayLength, GenericArray},
FieldBytes, FieldBytesSize, ScalarPrimitive,
Expand Down Expand Up @@ -321,22 +318,6 @@ where
{
}

impl<C> Debug for Signature<C>
where
C: PrimeCurve,
SignatureSize<C>: ArrayLength<u8>,
{
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "ecdsa::Signature<{:?}>(", C::default())?;

for byte in self.to_bytes() {
write!(f, "{:02X}", byte)?;
}

write!(f, ")")
}
}

impl<C> From<Signature<C>> for SignatureBytes<C>
where
C: PrimeCurve,
Expand Down Expand Up @@ -367,6 +348,22 @@ where
}
}

impl<C> fmt::Debug for Signature<C>
where
C: PrimeCurve,
SignatureSize<C>: ArrayLength<u8>,
{
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "ecdsa::Signature<{:?}>(", C::default())?;

for byte in self.to_bytes() {
write!(f, "{:02X}", byte)?;
}

write!(f, ")")
}
}

impl<C> fmt::Display for Signature<C>
where
C: PrimeCurve,
Expand Down