Skip to content

ecdsa: add RFC5480 citation for der::Signature #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Apr 13, 2023
Merged

ecdsa: add RFC5480 citation for der::Signature #710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ecdsa/src/der.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
//! Support for ECDSA signatures encoded as ASN.1 DER.
//! Support for ASN.1 DER-encoded ECDSA signatures as specified in
//! [RFC5480 Appendix A].
//!
//! [RFC5480 Appendix A]: https://www.rfc-editor.org/rfc/rfc5480#appendix-A

use crate::{Error, Result};
use core::{
Expand Down Expand Up @@ -43,9 +46,16 @@ pub type MaxSize<C> = <<FieldBytesSize<C> as Add>::Output as Add<MaxOverhead>>::
/// Byte array containing a serialized ASN.1 signature
type SignatureBytes<C> = GenericArray<u8, MaxSize<C>>;

/// ASN.1 DER-encoded signature.
/// ASN.1 DER-encoded signature as specified in [RFC5480 Appendix A]:
///
/// Generic over the scalar size of the elliptic curve.
/// ```text
/// ECDSA-Sig-Value ::= SEQUENCE {
/// r INTEGER,
/// s INTEGER
/// }
/// ```
///
/// [RFC5480 Appendix A]: https://www.rfc-editor.org/rfc/rfc5480#appendix-A
pub struct Signature<C>
where
C: PrimeCurve,
Expand Down