Add BlockArray abstraction to handle fallible allocations #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradludgate
changed the title
conradludgate
force-pushed
the
argon2-fallible-alloc
branch
from
0fec952 to
c28f547
Compare
…_zeroed as an optimisation
conradludgate
force-pushed
the
argon2-fallible-alloc
branch
from
c28f547 to
4f74add
Compare
Member
|
Sorry, I had my own draft. I published it as #568. I borrowed some things from your PR (e.g. I did not know about |
Contributor
Author
|
No harm done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #566.
There was an open question regarding alignment. I couldn't demonstrate any significant performance benefit from unaligned allocations, so I skipped that here.
I wasn't sure what error to return. I decided not to introduce a breaking change here with a new error variant, but perhaps that is desired.