blake2bp/blake2sp #70
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you! Can you please fix the CI failures? Looks like you are not handling big-endian correctly and use absolute path which do not work in Rust 1.21. |
Contributor
Author
|
Fixed the bugs; also added bp/sp benchmarks. |
Member
|
@kazcw are you still interested in landing this and if so, can you rebase please? |
Contributor
Author
|
@tarcieri Upstream has seen enough change in the last year and a half that I think it would be easier to start over than reconcile this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-std (single-threaded) implementation.
Tests included are the official test vectors plus a long-input case.
cf. #31