Misc. improvements for x509-certs #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmccallum
force-pushed
the
misc
branch
3 times, most recently
from
c484094 to
c8bca8d
Compare
Member
|
Re: The advantage over @baloo it'd be good if you can take a look at this to see if it overlaps with what you've been working on |
baloo
reviewed
Jan 9, 2023
baloo
approved these changes
Jan 9, 2023
Member
|
no overlap that I can see, all of it makes sense. |
tarcieri
reviewed
Jan 9, 2023
These just duplicate the Decode trait and are inconsistently implemented. Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
Signed-off-by: Nathaniel McCallum <[email protected]>
RustCrypto#806 The above PR made most types in this crate owned. However, some types were missed. For consistencey, complete the migration. Signed-off-by: Nathaniel McCallum <[email protected]>
This crate unconditionally requires alloc. Signed-off-by: Nathaniel McCallum <[email protected]>
This was referenced Mar 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.