der: missing impl TryFrom<AnyRef> #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
changed the title
baloo
commented
Jan 3, 2023
| @@ -1,17 +1,47 @@ | |||
| macro_rules! impl_string_type { | |||
| macro_rules! impl_type { | |||
Member
Author
There was a problem hiding this comment.
I splitted it as I think I can just reuse this in BitString, GeneralizedTime, Int*, OctetString and UtcTime
baloo
force-pushed
the
baloo/owned-api/missing-tryfrom
branch
2 times, most recently
from
697ba62 to
b822b68
Compare
This removes some duplication but most importantly adds the missing implementations.
baloo
force-pushed
the
baloo/owned-api/missing-tryfrom
branch
from
b822b68 to
32fcd62
Compare
tarcieri
approved these changes
Jan 4, 2023
Member
tarcieri
left a comment
tarcieri
left a comment
There was a problem hiding this comment.
Looks like a nice refactor, albeit a bit hard to review.
If you're happy with this I can merge.
Member
Author
|
Yeah, there is some noise. It's slightly easier with whitespace removed. I don't have much to add, this was mostly shuffling stuff around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some duplication but most importantly adds the missing implementations.