Skip to content

x509-cert: Serial numbers are formated as printable string #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 2 commits into from
Dec 13, 2022
Merged

x509-cert: Serial numbers are formated as printable string #794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edd49a1
x509-cert: Serial numbers are formated as printable string
baloo Dec 13, 2022
4b53659
Update x509-cert/src/attr.rs
baloo Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion x509-cert/src/attr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! Attribute-related definitions as defined in X.501 (and updated by RFC 5280).

use alloc::vec::Vec;
use const_oid::db::rfc4519::{COUNTRY_NAME, DOMAIN_COMPONENT};
use const_oid::db::rfc4519::{COUNTRY_NAME, DOMAIN_COMPONENT, SERIAL_NUMBER};
use core::fmt::{self, Write};

use const_oid::db::DB;
Expand Down Expand Up @@ -185,6 +185,9 @@ impl AttributeTypeAndValue<'_> {
let tag = match oid {
COUNTRY_NAME => Tag::PrintableString,
DOMAIN_COMPONENT => Tag::Ia5String,
// Serial numbers are formated as Printable String as per RFC 5280 Appendix A.1:
// https://datatracker.ietf.org/doc/html/rfc5280#appendix-A.1
SERIAL_NUMBER => Tag::PrintableString,
_ => Tag::Utf8String,
};

Expand Down