der: add *Ref to reference types in asn1 module
#637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
der/add-ref-to-reference-type-names
branch
from
b8f6612 to
ac2721a
Compare
Now that we have a `DecodeOwned` trait and initial support for on-the-fly PEM decoding, it makes sense to add owned forms of all of the various reference types. This brings up a question of naming: we can either add `*Owned` to all of the owned types or add a `*Ref` to all of the existing reference types. This PR chooses to do the latter, renaming all of the reference types to make room for the owned types. Owned types are easier to work with and probably preferable for anyone who can depend on `alloc` existing, so this PR gives them the shorter name. The following types are renamed: - `Any` => `AnyRef` - `BitString` => `BitStringRef` - `Ia5String` => `Ia5StringRef` - `OctetString` => `OctetStringRef` - `PrintableString` => `PrintableStringRef` - `Utf8String` => `Utf8StringRef` Also renames the newly introduced `BitStringOwned` type to `BitString`.
tarcieri
force-pushed
the
der/add-ref-to-reference-type-names
branch
from
ac2721a to
f7e903a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a
DecodeOwnedtrait and initial support for on-the-fly PEM decoding, it makes sense to add owned forms of all of the various reference types.This brings up a question of naming: we can either add
*Ownedto all of the owned types or add a*Refto all of the existing reference types.This PR chooses to do the latter, renaming all of the reference types to make room for the owned types.
Owned types are easier to work with and probably preferable for anyone who can depend on
allocexisting, so this PR gives them the shorter name.The following types are renamed:
Any=>AnyRefBitString=>BitStringRefIa5String=>Ia5StringRefOctetString=>OctetStringRefPrintableString=>PrintableStringRefUtf8String=>Utf8StringRefAlso renames the newly introduced
BitStringOwnedtype toBitString.