der: add streaming on-the-fly PemDecoder and BitStringOwned
#636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a PEM decoder which leverages the `Reader` trait to be able to decode DER from PEM being decoded on-the-fly. This requires bounding on `DecodeOwned`, as it's not possible to borrow DER bytes from a PEM input. Also adds `BitStringOwned`, an owned form of `BitString`. This may not be the greatest naming scheme (perhaps we should change the current `BitString` type to `BitStringRef`). There are several owned types to add. However this much is capable of decoding some SPKI test vectors.
tarcieri
force-pushed
the
der/streaming-pem-decoder
branch
from
9dc6f8e to
8d93b9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a PEM decoder which leverages the
Readertrait to be able to decode DER from PEM being decoded on-the-fly. This requires bounding onDecodeOwned, as it's not possible to borrow DER bytes from a PEM input.Also adds
BitStringOwned, an owned form ofBitString. This may not be the greatest naming scheme (perhaps we should change the currentBitStringtype toBitStringRef).There are several owned types to add. However this much is capable of decoding some SPKI test vectors.