der: add EncodeRef/EncodeValueRef; remove OptionalRef
#604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds generic wrapper types for encoding references to types which impl encoding traits: - `EncodeRef`: impls `Encode` for &T where T: `Encode` - `EncodeValueRef`: impls `EncodeValue` and `Tagged` for &T This, in conjunction with impls for `&Option<T>`, eliminates the need to have a dedicated `OptionalRef` type. The `ContextSpecificRef` type is retained as it's a useful constructor for use in proc macros. All in all it would be nice to have a better solution like this, like a blanket impl of `Encode` for &T where T: `Encode`. That's a direction which may still be worth exploring, but in the meantime the wrapper types mean there's a generic solution for reference type encoding.
tarcieri
force-pushed
the
der/encode-ref
branch
from
feff29c to
a96eb46
Compare
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #527.
Adds generic wrapper types for encoding references to types which impl encoding traits:
EncodeRef: implsEncodefor &T where T:EncodeEncodeValueRef: implsEncodeValueandTaggedfor &TThis, in conjunction with impls for
&Option<T>, eliminates the need to have a dedicatedOptionalReftype.The
ContextSpecificReftype is retained as it's a useful constructor for use in proc macros.All in all it would be nice to have a better solution like this, like a blanket impl of
Encodefor &T where T:Encode. That's a direction which may still be worth exploring, but in the meantime the wrapper types mean there's a generic solution for reference type encoding.