feat(const-oid): add additional RFCs to the OID DB #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RFC 5911 * RFC 5912 * RFC 6268 * RFC 7107 * RFC 7299 Signed-off-by: Nathaniel McCallum <[email protected]>
tarcieri
reviewed
Mar 2, 2022
Comment on lines
+889
to
+890
| hMAC-SHA1 OBJECT IDENTIFIER ::= { iso(1) identified-organization(3) | ||
| dod(6) internet(1) security(5) mechanisms(5) 8 1 2 } |
Member
There was a problem hiding this comment.
Huh, some funky capitalization there which is reflected in the generated code. It is what it is, I guess...
Contributor
Author
There was a problem hiding this comment.
@tarcieri Yeah. I can't change history. However, at least we output something sane:
pub const HMAC_SHA_1: crate::NamedOid<'_> = crate::NamedOid {
oid: crate::ObjectIdentifier::new("1.3.6.1.5.5.8.1.2"),
name: "hMAC-SHA1",
};
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nathaniel McCallum [email protected]