feat: add new NewType derive #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tarcieri Let me know if you like this approach or not. I have a bunch of types it could apply to. Particularly, x509 extensions. |
Member
|
Hmmm, interesting. It kind of makes sense. Let me think about it a bit more. |
Contributor
Author
Member
|
I guess this is fine. My only remaining concern is that "newtype" is pretty much exclusively used as a closed compound word, in which case the proper Rust capitalization is "Newtype" |
There are a number of der types that could benefit from wrapping in a newtype. For example, `RelativeDistinguishedName` could benefit from an `impl Display` to convert it to a string representation. But because it is just `Vec<AttributeTypeAndValue>` we can't really do this. Having a systematic way to derive newtypes in these cases is thus beneficial. Signed-off-by: Nathaniel McCallum <[email protected]>
Contributor
Author
|
@tarcieri I have renamed |
tarcieri
approved these changes
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of der types that could benefit from wrapping in a
newtype. For example,
RelativeDistinguishedNamecould benefit froman
impl Displayto convert it to a string representation. But becauseit is just
Vec<AttributeTypeAndValue>we can't really do this.Having a systematic way to derive newtypes in these cases is thus
beneficial.
Signed-off-by: Nathaniel McCallum [email protected]