base64ct: add bounds for Encoding/Variant ZSTs
#405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deriving traits like `Copy`, `Clone`, and `Debug` on types which include an encoding as a generic parameter is presently problematic because there are no trait bounds specified. These traits, `Encoding` and the sealed `Variant` which receives a blanket impl of the former, are not intended to be implemented by types outside of this crate. While adding bounds is technically a breaking change, it would be highly unexpected for this to have any real-world impact as external crates should only be consuming these traits and using them with the encoding ZSTs defined in this crate.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deriving traits like
Copy,Clone, andDebugon types which include an encoding as a generic parameter is presently problematic because there are no trait bounds specified.These traits,
Encodingand the sealedVariantwhich receives a blanket impl of the former, are not intended to be implemented by types outside of this crate. While adding bounds is technically a breaking change, it would be highly unexpected for this to have any real-world impact as external crates should only be consuming these traits and using them with the encoding ZSTs defined in this crate.