base64ct: impl std::io::Read for Decoder
#404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionally impls the `Read` trait when the `std` feature is enabled.
tarcieri
force-pushed
the
base64ct/std-io-read
branch
from
0679992 to
0736740
Compare
tarcieri
added a commit
that referenced
this pull request
Feb 9, 2022
Modifies `pem_rfc7468::Decoder` to be a wrapper around the buffered `base64ct::Decoder` type. This allows incrementally decoding PEM, as opposed to a one-shot approach, however support for one-shot decoding is still preserved as a set of static functions which previously served as the crate's primary API, meaning this should not be a breaking change for most current applications. Additionally impls `std::io::Read` for `pem_rfc7468::Decoder`, delegating to the `std::io::Read` implementation added to `base64ct::Decoder` in #404.
tarcieri
added a commit
that referenced
this pull request
Feb 9, 2022
Modifies `pem_rfc7468::Decoder` to be a wrapper around the buffered `base64ct::Decoder` type. This allows incrementally decoding PEM, as opposed to a one-shot approach, however support for one-shot decoding is still preserved as a set of static functions which previously served as the crate's primary API, meaning this should not be a breaking change for most current applications. Additionally impls `std::io::Read` for `pem_rfc7468::Decoder`, delegating to the `std::io::Read` implementation added to `base64ct::Decoder` in #404.
tarcieri
added a commit
that referenced
this pull request
Feb 9, 2022
Modifies `pem_rfc7468::Decoder` to be a wrapper around the buffered `base64ct::Decoder` type. This allows incrementally decoding PEM, as opposed to a one-shot approach, however support for one-shot decoding is still preserved as a set of static functions which previously served as the crate's primary API, meaning this should not be a breaking change for most current applications. Additionally impls `std::io::Read` for `pem_rfc7468::Decoder`, delegating to the `std::io::Read` implementation added to `base64ct::Decoder` in #404.
tarcieri
added a commit
that referenced
this pull request
Feb 9, 2022
Modifies `pem_rfc7468::Decoder` to be a wrapper around the buffered `base64ct::Decoder` type. This allows incrementally decoding PEM, as opposed to a one-shot approach, however support for one-shot decoding is still preserved as a set of static functions which previously served as the crate's primary API, meaning this should not be a breaking change for most current applications. Additionally impls `std::io::Read` for `pem_rfc7468::Decoder`, delegating to the `std::io::Read` implementation added to `base64ct::Decoder` in #404.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally impls the
Readtrait when thestdfeature is enabled.