der: add SequenceRef type
#374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a type which wraps the value portion / "body" of a DER-serialized `SEQUENCE`. This type subsumes the previous decoding logic for `Decoder::sequence`, parsing the `SEQUENCE` using `DecodeValue` and storing its position within the outer document. In addition to simplifying the sequence decoding logic, this also makes it possible to use this type within the `Sequence` proc macro, which will allow it to impl `DecodeValue`. However, that work is left for a followup PR.
tarcieri
force-pushed
the
der/sequenceref
branch
from
9dcf51a to
d079dcd
Compare
tarcieri
commented
Feb 1, 2022
| /// Get the position within the buffer. | ||
| pub fn position(&self) -> Length { | ||
| self.position | ||
| // TODO(tarcieri): avoid potential panic here |
Member
Author
There was a problem hiding this comment.
This can probably be addressed by incrementing both position and offset when data is read. This was a quick workaround to get everything initially working.
tarcieri
added a commit
that referenced
this pull request
Feb 1, 2022
The proc macro previously derived the `Decode` trait, which is not composable with context-specific fields, which depend on the `DecodeValue` trait in order to support IMPLICIT fields. This commit changes the custom derive macro for `Sequence` to produce a `DecodeValue` impl instead of `Decode`. This leverages the newly introduced `SequenceRef` type from #374.
tarcieri
added a commit
that referenced
this pull request
Feb 1, 2022
The proc macro previously derived the `Decode` trait, which is not composable with context-specific fields, which depend on the `DecodeValue` trait in order to support IMPLICIT fields. This commit changes the custom derive macro for `Sequence` to produce a `DecodeValue` impl instead of `Decode`. This leverages the newly introduced `SequenceRef` type from #374.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a type which wraps the value portion / "body" of a DER-serialized
SEQUENCE.This type subsumes the previous decoding logic for
Decoder::sequence, parsing theSEQUENCEusingDecodeValueand storing its position within the outer document.In addition to simplifying the sequence decoding logic, this also makes it possible to use this type within the
Sequenceproc macro, which will allow it to implDecodeValue. However, that work is left for a followup PR.