der: make OrdIsValueOrd into sealed trait
#359
Merged
+21
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this trait is useful for defining the `ValueOrd` impl for various ASN.1 universal types within the `der` crate itself, it is easily abused outside the context of the `der` crate. `ValueOrd` handles comparing DER serializations for ordering. The `OrdIsValueOrd` is tempting in that it makes it appear that `Ord` can be used instead, but this only works in hyper-specific cases where `Ord` is identical to `ValueOrd`, which is primarily the ASN.1 universal types. To prevent misuse, this commit seals the trait to force downstream users to impl `ValueOrd`.
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this trait is useful for defining the
ValueOrdimpl for various ASN.1 universal types within thedercrate itself, it is easily abused outside the context of thedercrate.ValueOrdhandles comparing DER serializations for ordering. TheOrdIsValueOrdis tempting in that it makes it appear thatOrdcan be used instead, but this only works in hyper-specific cases whereOrdis identical toValueOrd, which is primarily the ASN.1 universal types.To prevent misuse, this commit seals the trait to force downstream users to impl
ValueOrd.