Skip to content

der: read_nested: check header length matches contents of IMPLICIT #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tarcieri merged 2 commits into from
Apr 21, 2025
Merged

der: read_nested: check header length matches contents of IMPLICIT #1739

tarcieri merged 2 commits into from
Apr 21, 2025

Conversation

@dishmaker
Copy link
Contributor

@dishmaker dishmaker commented Mar 25, 2025

Fixes #1738

@dishmaker
Copy link
Contributor Author

dishmaker commented Mar 25, 2025 •
edited
Loading

Depends on:

Breaks test in x509-cert/tests/pkix_extensions.rs
https://github.com/RustCrypto/formats/pull/1545/files#diff-adb3729d388b26047202e8a442d9fe78eb2a2857d61adb6ad87bffc57f65aa51L1195

@dishmaker dishmaker marked this pull request as draft March 25, 2025 09:49
@dishmaker dishmaker force-pushed the dishmaker/fix_implicit_read_nested branch from 3c2086d to 442e3e3 Compare April 21, 2025 00:43
@dishmaker dishmaker marked this pull request as ready for review April 21, 2025 00:43
@dishmaker
Copy link
Contributor Author

dishmaker commented Apr 21, 2025

Short PR :)

@tarcieri tarcieri merged commit d933c0d into RustCrypto:master Apr 21, 2025
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

der: IMPLICIT allows out-of-bounds decode

2 participants

@dishmaker @tarcieri