der: deprecate TagNumber::new
#1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
you'll need to exclude changes made to |
tarcieri
force-pushed
the
der/deprecate-tag-number-new
branch
from
851824f to
e814957
Compare
After #1651 the inner `u32` of `TagNumber` is now `pub` and the `TagNumber::new` function no longer maintains an invariant (which it previously did by panicking when tag numbers are out-of-range). With the field now `pub` there is no longer a need to call a function to construct a `TagNumber`, instead it can be done directly.
tarcieri
force-pushed
the
der/deprecate-tag-number-new
branch
from
e814957 to
d6c2943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1651 the inner
u32ofTagNumberis nowpuband theTagNumber::newfunction no longer maintains an invariant (which it previously did by panicking when tag numbers are out-of-range).With the field now
pubthere is no longer a need to call a function to construct aTagNumber, instead it can be done directly.