Upgrade all crates to the 2024 edition and bump MSRV to 1.85 #1670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I’d say go ahead and do |
baloo
force-pushed
the
baloo/edition-2024
branch
4 times, most recently
from
005719e to
15a8a2c
Compare
Member
|
Let me get #1671 out first and then you can rebase on top of it |
Member
baloo
force-pushed
the
baloo/edition-2024
branch
from
15a8a2c to
519a199
Compare
Merged
baloo
added a commit
to baloo/formats
that referenced
this pull request
Feb 26, 2025
Added - derive additional traits on alphabets (RustCrypto#1578) Changed - MSRV 1.85 // Edition 2024 (RustCrypto#1670) - reject zero-length decode requests (RustCrypto#1387) - use `core::error::Error` (RustCrypto#1681)
Merged
baloo
added a commit
that referenced
this pull request
Feb 26, 2025
Merged
tarcieri
added a commit
that referenced
this pull request
May 15, 2025
We kept `base64ct` out of the toplevel workspace because we can't run tests on it with its previous MSRV of 1.81 because that compiler can't recognize the newer edition on all of the other crates in the workspace. We originally attempted this upgrade in #1670 but reverted it in #1702 due to complaints we received in #1695. Now that the needed MSRV of 1.85 is `N-2` of the current 1.87 stable, we can hopefully perform this upgrade without receiving as many complaints. Several other crates have bumped edition to 2024 already, and edition upgrades are a time when MSRV bumps like this should be expected.
tarcieri
added a commit
that referenced
this pull request
May 15, 2025
We kept `base64ct` out of the toplevel workspace because we can't run tests on it with its previous MSRV of 1.81 because that compiler can't recognize the newer edition on all of the other crates in the workspace. We originally attempted this upgrade in #1670 but reverted it in #1702 due to complaints we received in #1695. Now that the needed MSRV of 1.85 is `N-2` of the current 1.87 stable, we can hopefully perform this upgrade without receiving as many complaints. Several other crates have bumped edition to 2024 already, and edition upgrades are a time when MSRV bumps like this should be expected.
tarcieri
added a commit
that referenced
this pull request
May 15, 2025
) We kept `base64ct` out of the toplevel workspace because we can't run tests on it with its previous MSRV of 1.81 because that compiler can't recognize the newer edition on all of the other crates in the workspace. We originally attempted this upgrade in #1670 but reverted it in #1702 due to complaints we received in #1695. Now that the needed MSRV of 1.85 is `N-2` of the current 1.87 stable, we can hopefully perform this upgrade without receiving as many complaints. Several other crates have bumped edition to 2024 already, and edition upgrades are a time when MSRV bumps like this should be expected.
This was referenced Aug 20, 2025
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
x509-certand its dependents from the workspace for now, until we get the chance to upgrade its dependencies.