pkcs5: remove lifetimes #1195
pkcs5: remove lifetimes #1195
Conversation
| @@ -0,0 +1,104 @@ | |||
| //! Salt storage buffer which works on heapless `no_std` targets. | |||
| // TODO(tarcieri): use `ArrayVec` when it's available in `core`. | |||
There was a problem hiding this comment.
It might be worth considering making a crate like arrayvec or tinyvec an optional dependency of der so it can implement much of the boilerplate below.
There are a few places we use fixed-sized buffers like this where it would be nice, I believe.
tarcieri
force-pushed
the
pkcs5/remove-lifetimes
branch
from
2b1e55d to
057cee0
Compare
|
Ha, well. That makes it easy, but we lose the |
|
No need for them if everything can always be owned! Unlike any of the other types these have a fairly fixed upper bound which isn't too big. I can go ahead and make the changes to the other crates so the tests pass if you're okay with this. I guess you'd need to rebase your changes on this PR to fully split I guess we can probably move to making breaking changes soon too. |
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
tarcieri
force-pushed
the
pkcs5/remove-lifetimes
branch
from
ebe2b2c to
15e5b44
Compare
Removes lifetimes from all types in the `pkcs5` crate, making them own their data.
Signed-off-by: Arthur Gautier <[email protected]>
tarcieri
force-pushed
the
pkcs5/remove-lifetimes
branch
from
15e5b44 to
14e9b2d
Compare
tarcieri
force-pushed
the
pkcs5/remove-lifetimes
branch
from
a5d452e to
f7d998d
Compare
Removes lifetimes from all types in the
pkcs5crate, making them own their data.cc @baloo