Skip to content

der: provide a noop implementation for PhantomData #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Apr 18, 2023
Merged

der: provide a noop implementation for PhantomData #1012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion der/src/ord.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! Ordering trait.

use crate::{EncodeValue, Result, Tagged};
use core::cmp::Ordering;
use core::{cmp::Ordering, marker::PhantomData};

/// DER ordering trait.
///
Expand Down Expand Up @@ -69,3 +69,17 @@ where

Ok(length_ord)
}

/// Provide a no-op implementation for PhantomData
impl<T> ValueOrd for PhantomData<T> {
fn value_cmp(&self, _other: &Self) -> Result<Ordering> {
Ok(Ordering::Equal)
}
}

/// Provide a no-op implementation for PhantomData
impl<T> DerOrd for PhantomData<T> {
fn der_cmp(&self, _other: &Self) -> Result<Ordering> {
Ok(Ordering::Equal)
}
}