Skip to content

RsaPssParams and RsaOaepParams fixes #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tarcieri merged 2 commits into from
Apr 18, 2023
Merged

RsaPssParams and RsaOaepParams fixes #1010

tarcieri merged 2 commits into from
Apr 18, 2023

Conversation

@lumag
Copy link
Contributor

@lumag lumag commented Apr 18, 2023

  • Use NULL parameters for digest params (as required by mozilla)
  • Add functions to construct known-good parameters.

@lumag
pkcs1: params: use NULL parameters for SHA AlgorithmIdentifiers
9eb0004 
Obviously Mozilla policy insists on having NULL parameters for MD/SHA
algorithm identifiers. Change RsaPssParams/RsaOaepParams defaults to
use NULL instead of empty parameters.

Signed-off-by: Dmitry Baryshkov <[email protected]>
@lumag
Copy link
Contributor Author

lumag commented Apr 18, 2023

@tarcieri if possible, could you please cut the pkcs1 release afterwards?
I'd like to use this in RSA crate to fix issues in #1007 (ugh).

tarcieri
tarcieri reviewed Apr 18, 2023
View reviewed changes
tarcieri
tarcieri reviewed Apr 18, 2023
View reviewed changes
@tarcieri
Copy link
Member

tarcieri commented Apr 18, 2023

This looks mostly ok though I'm a bit curious about the usage of &'a dyn AsRef<[u8]> as opposed to &'a impl AsRef<[u8]> or just &'a [u8]

@lumag
pkcs1: params: provide functions to construct RsaPss and RsaOaepParams
837e6e3 
Implement RsaPssParams::new() and RsaOaepParams::new(), two functions to
generate correct parameters for the provided Digest and data.

Signed-off-by: Dmitry Baryshkov <[email protected]>
@tarcieri tarcieri merged commit 8c62e09 into RustCrypto:master Apr 18, 2023
@tarcieri tarcieri mentioned this pull request Apr 18, 2023
Merged
@lumag lumag deleted the pkcs1-params branch April 18, 2023 15:03
@lumag
Copy link
Contributor Author

lumag commented Apr 18, 2023

@tarcieri thank you!

@lumag lumag mentioned this pull request Apr 18, 2023
Merged
baloo added a commit to baloo/formats that referenced this pull request May 23, 2024
@baloo
[wip] pkcs1: make sure AlgorithmIdentifier is encoded with Any
e1e7d61 
reverts parts of RustCrypto#799 and RustCrypto#1010
@baloo baloo mentioned this pull request May 23, 2024
Closed
baloo added a commit to baloo/formats that referenced this pull request May 23, 2024
@baloo
[wip] pkcs1: make sure AlgorithmIdentifier is encoded with Any
e28a8ea 
reverts parts of RustCrypto#799 and RustCrypto#1010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieri tarcieri tarcieri left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lumag @tarcieri