Skip to content

primeorder: support curves with any a #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 4 commits into from
Feb 6, 2023
Merged

primeorder: support curves with any a #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b11bc7
Introduce PointArithmetic trait
survived Feb 6, 2023
118c466
Update other crates
survived Feb 6, 2023
97908f4
Fix clippy warnings
survived Feb 6, 2023
0cb24bb
Hide PointArithmetic trait
survived Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions p256/src/arithmetic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ pub(crate) mod util;
use self::{field::FieldElement, scalar::Scalar};
use crate::NistP256;
use elliptic_curve::{CurveArithmetic, PrimeCurveArithmetic};
use primeorder::{equation_a, PrimeCurveParams};
use primeorder::{point_arithmetic, PrimeCurveParams};

/// Elliptic curve point in affine coordinates.
pub type AffinePoint = primeorder::AffinePoint<NistP256>;
Expand All @@ -36,7 +36,7 @@ impl PrimeCurveArithmetic for NistP256 {
/// [NIST SP 800-186]: https://csrc.nist.gov/publications/detail/sp/800-186/final
impl PrimeCurveParams for NistP256 {
type FieldElement = FieldElement;
type EquationAProperties = equation_a::IsMinusThree;
type PointArithmetic = point_arithmetic::EquationAIsMinusThree;

/// a = -3
const EQUATION_A: FieldElement = FieldElement::from_u64(3).neg();
Expand Down
4 changes: 2 additions & 2 deletions p384/src/arithmetic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pub(crate) mod scalar;
use self::{field::FieldElement, scalar::Scalar};
use crate::NistP384;
use elliptic_curve::{CurveArithmetic, PrimeCurveArithmetic};
use primeorder::{equation_a, PrimeCurveParams};
use primeorder::{point_arithmetic, PrimeCurveParams};

/// Elliptic curve point in affine coordinates.
pub type AffinePoint = primeorder::AffinePoint<NistP384>;
Expand All @@ -38,7 +38,7 @@ impl PrimeCurveArithmetic for NistP384 {
/// [NIST SP 800-186]: https://csrc.nist.gov/publications/detail/sp/800-186/final
impl PrimeCurveParams for NistP384 {
type FieldElement = FieldElement;
type EquationAProperties = equation_a::IsMinusThree;
type PointArithmetic = point_arithmetic::EquationAIsMinusThree;

/// a = -3 (0xfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffeffffffff0000000000000000fffffffc)
const EQUATION_A: FieldElement = FieldElement::from_u64(3).neg();
Expand Down
34 changes: 0 additions & 34 deletions primeorder/src/equation_a.rs
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions primeorder/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#![warn(missing_docs, rust_2018_idioms, unused_qualifications)]
#![doc = include_str!("../README.md")]

pub mod equation_a;
pub mod point_arithmetic;

mod affine;
mod field;
Expand All @@ -30,8 +30,8 @@ pub trait PrimeCurveParams:
/// Base field element type.
type FieldElement: PrimeField<Repr = FieldBytes<Self>>;

/// Special properties of the `a`-coefficient.
type EquationAProperties: equation_a::EquationAProperties;
/// [Point arithmetic](point_arithmetic) implementation, might be optimized for this specific curve
type PointArithmetic: point_arithmetic::PointArithmetic<Self>;

/// Coefficient `a` in the curve equation.
const EQUATION_A: Self::FieldElement;
Expand Down
Loading