Int - inv_mod
#727
Closed
Int - inv_mod
#727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-3milabs
commented
Jan 8, 2025
Comment on lines
-446
to
449
| /// Compute `1 / self mod p`. | ||
| pub trait InvMod: Sized { | ||
| pub trait InvMod<Rhs = Self, Output = Self>: Sized { | ||
| /// Compute `1 / self mod p`. | ||
| fn inv_mod(&self, p: &Self) -> CtOption<Self>; | ||
| fn inv_mod(&self, p: &Rhs) -> CtOption<Output>; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This solution should (in theory?) just be an addition, not a breaking change.
However, perhaps the following solution might be neater:
pub trait InvMod: Sized {
type Modulus;
type Output;
/// Compute `1 / self mod p`.
fn inv_mod(&self, p: &Self::Modulus) -> Self::Output;
}@tarcieri let's have a discussion about this to see what works best.
10 tasks
This was referenced Jan 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
Int::inv_modoperation.Status: awaiting the merge of #722.