Fix modulus leading zeros calculation for (Boxed)MontyForm
#713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Member
|
Can you add a regression test as well? |
Merged
Signed-off-by: Andrew Whitehead <[email protected]>
andrewwhitehead
force-pushed
the
fix/mod-leading-zeros
branch
from
5a735a5 to
b428f80
Compare
tarcieri
changed the title
MontyForm
fjarri
reviewed
Dec 11, 2024
|
|
||
| let mut rng = rand_chacha::ChaCha8Rng::seed_from_u64(1); | ||
| for n in 0..1000 { | ||
| for n in 0..1500 { |
Contributor
There was a problem hiding this comment.
Probably would be more reliable to have a specialized regression test. And a proptest instead of iterating a 1000 times.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #707