Add radix string encoding for Uint, BoxedUint #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
andrewwhitehead
force-pushed
the
feat/to_str_radix_vartime
branch
from
34db4a8 to
fba6be5
Compare
fjarri
reviewed
Aug 21, 2024
Signed-off-by: Andrew Whitehead <[email protected]>
Contributor
|
I'm not sure if this PR is in finished state now, or still WIP, but I think it would be useful to some doc comments for the new structures and methods - it's pretty hard to guess the exact contracts right now. |
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Contributor
Author
|
Added a few doc comments. I think the only question I have is whether the methods should panic on an invalid radix (consistent with the stdlib |
Contributor
|
I'd say |
tarcieri
approved these changes
Sep 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.