Implement from_str_radix_vartime for Uint, BoxedUint
#603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Closed
|
Is this already fully working or still a WIP? |
Contributor
Author
|
It's fully working. I have encoding done too (to_string_radix_vartime), but I didn't want to submit too many changes at once. |
|
That will be a must, was about to start working on a solution for it locally but it's great to know this is being added 🙏🏻 |
|
When do you estimate both from and to methods will be available? |
Member
|
@ndavd I have a lot on my plate right now and higher priority issues to work on, even in this crate. It will also be going into a prerelease, and we likely won't have a final release out for several months. |
tarcieri
reviewed
Jul 26, 2024
Comment on lines
+541
to
+574
| /// Possible errors in variable-time integer decoding methods. | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq)] | ||
| pub enum DecodeError { | ||
| /// The input value was empty. | ||
| Empty, | ||
|
|
||
| /// The input was not consistent with the format restrictions. | ||
| InvalidDigit, | ||
|
|
||
| /// Input size is too small to fit in the given precision. | ||
| InputSize, | ||
|
|
||
| /// The deserialized number is larger than the given precision. | ||
| Precision, | ||
| } | ||
|
|
||
| impl fmt::Display for DecodeError { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| match self { | ||
| Self::Empty => write!(f, "empty value provided"), | ||
| Self::InvalidDigit => { | ||
| write!(f, "invalid digit character") | ||
| } | ||
| Self::InputSize => write!(f, "input size is too small to fit in the given precision"), | ||
| Self::Precision => write!( | ||
| f, | ||
| "the deserialized number is larger than the given precision" | ||
| ), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #[cfg(feature = "std")] | ||
| impl std::error::Error for DecodeError {} |
Member
There was a problem hiding this comment.
Seems like an odd place for this. Perhaps we should extract an errors.rs. But I'll save that for another PR.
tarcieri
changed the title
from_str_radix_vartime for Uint, BoxedUint
tarcieri
approved these changes
Jul 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds fallible parsing for binary, decimal, and hex integers (and any base from 2 to 36).
The format of these numbers generally matches the
from_str_radixmethods of the standard library. One exception is that underscores may used as spacers, as in+1_000_000for example. This is consistent with thenum_bigintcrate.The
DecodeErrorenum is promoted from the uint.boxed module and reused.