Skip to content

Make Uint::split const generic over inputs #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tarcieri merged 1 commit into from
Jan 16, 2024
Merged

Make Uint::split const generic over inputs #557

tarcieri merged 1 commit into from
Jan 16, 2024

Conversation

@tarcieri
Copy link
Member

@tarcieri tarcieri commented Jan 16, 2024

This allows a const fn to be written which is bounded on the Split trait, and generic over a number of input limbs.

It replaces the previous macro-defined version.

@tarcieri
Make Uint::split const generic over inputs
e044797 
This allows a `const fn` to be written which is bounded on the `Split`
trait, and generic over a number of input limbs.
@tarcieri tarcieri merged commit f176122 into master Jan 16, 2024
@tarcieri tarcieri deleted the uint/split-generic-method branch January 16, 2024 18:27
tarcieri added a commit that referenced this pull request Jan 16, 2024
@tarcieri
Refactor Uint::{concat, concat_mixed}
65cf776 
Does a similar treatment to what #556 and #557 did for `split*` methods,
moving `concat_mixed` to be a method on `Uint` that accepts `&self`,
making the method public, and redefining `Uint::concat` generically with
bounds on `Self: Concat`.
@tarcieri tarcieri mentioned this pull request Jan 16, 2024
Merged
tarcieri added a commit that referenced this pull request Jan 16, 2024
@tarcieri
Refactor Uint::{concat, concat_mixed} (#558)
8f4c7f5 
Does a similar treatment to what #556 and #557 did for `split*` methods,
moving `concat_mixed` to be a method on `Uint` that accepts `&self`,
making the method public, and redefining `Uint::concat` generically with
bounds on `Self: Concat`.
@tarcieri tarcieri mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarcieri