Add constant-time leading_zeros(), trailing_zeros(), bits(), and bit() for Uint
#153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjarri
force-pushed
the
zero-counting
branch
from
5cd6669 to
5f8da70
Compare
Member
|
Not sure... switching to cc @mikelodder7 |
Contributor
|
Seems fine to me |
Contributor
Author
|
Ok, I don't think it's worth it to do it in this PR, since there will be quite a few changes across the codebase. Filed #154 |
fjarri
force-pushed
the
zero-counting
branch
from
5f8da70 to
a5d8e78
Compare
tarcieri
approved these changes
Dec 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there some reason
bits_vartime()returnsusizeand notu32like the corresponding methods of primitive types?