Upgrade all crates to the 2024 edition and bump MSRV to 1.85 #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
changed the title
baloo
force-pushed
the
baloo/edition-2024
branch
2 times, most recently
from
d5fe39a to
7b79d26
Compare
baloo
force-pushed
the
baloo/edition-2024
branch
3 times, most recently
from
e09b3dd to
66b672d
Compare
newpavlov
reviewed
Feb 23, 2025
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
You also need to update hex-literal to v1.
baloo
force-pushed
the
baloo/edition-2024
branch
2 times, most recently
from
01ee216 to
7eb7c05
Compare
newpavlov
reviewed
Feb 23, 2025
aes/src/lib.rs
Outdated
| )] | ||
| #![cfg_attr(docsrs, feature(doc_auto_cfg))] | ||
| #![warn(missing_docs, rust_2018_idioms)] | ||
| #![allow(unsafe_op_in_unsafe_fn)] |
Member
There was a problem hiding this comment.
I think it's better to do this allow on the per-module basis like I did in the hashes PR. With potential target_feature improvements (which would make some intrinsics safe inside functions with with enabled target features) we may enable this lint back.
Member
Author
There was a problem hiding this comment.
Ha, I've tried to read the patch for hashes, but github UI is very slow. I've thought you've used a big unsafe{ block, but that was only in sha1, I should have kept reading, my bad.
Member
baloo
force-pushed
the
baloo/edition-2024
branch
from
7eb7c05 to
cc3c0c0
Compare
newpavlov
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.