Skip to content

Conversation

@Leo1003
Copy link
Contributor

@Leo1003 Leo1003 commented May 29, 2023

This PR adds implementation for the ciphers supported in OpenSSH.

Closes: #108

@williamdes
Copy link

Here is my public key using a Yubikey, is it implemented ?

[email protected] AAAAInNrLWVjZHNhLXNoYTItbmlzdHAyNTZAb3BlbnNzaC5jb20AAAAIbmlzdHAyNTYAAABBBHsGFeKSVIeBuAXGVxAyBqq5x55neL8R8XfQUrEGsUwNvf5xKyFwtM8hMY60TXqf/DtMMrGJl0eiAen4Lgs+BMwAAAAfc3NoOndpbGxpYW1kZXMreWJtLTIwMjNAd2Rlcy5mcg== [email protected]

@tarcieri
Copy link
Member

@williamdes this PR is adding symmetric ciphers for key encryption, not digital signature algorithms.

That said that key is using ECDSA/NIST P-256, which is supported by the latest release: https://docs.rs/ssh-key/latest/ssh_key/#supported-algorithms

@williamdes
Copy link

@williamdes this PR is adding symmetric ciphers for key encryption, not digital signature algorithms.

That said that key is using ECDSA/NIST P-256, which is supported by the latest release: https://docs.rs/ssh-key/latest/ssh_key/#supported-algorithms

Thanks for your kind reply
if I can be of some use to test stuff let me know

@Leo1003 Leo1003 marked this pull request as ready for review June 14, 2023 03:55
@Leo1003
Copy link
Contributor Author

Leo1003 commented Jun 19, 2023

I think this PR is ready for review.

This PR introduces three new features to control which cipher is supported:

  • des
  • chacha20poly1305
  • aes-cbc

Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tarcieri tarcieri merged commit b3dc879 into RustCrypto:master Jun 19, 2023
@tarcieri tarcieri mentioned this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plans to implement more ciphers in OpenSSH

3 participants