bump rand_core from 0.6.4 to 0.9.2; edition 2024; bump MSRV to 1.85
#478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
2 times, most recently
from
ca5074d to
79160ae
Compare
baloo
commented
Feb 14, 2025
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
3 times, most recently
from
e8d858e to
6402dde
Compare
baloo
changed the title
rand_core from 0.6.4 to 0.9.0rand_core from 0.6.4 to 0.9.1
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
2 times, most recently
from
3babac7 to
a61d022
Compare
newpavlov
reviewed
Feb 19, 2025
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
5 times, most recently
from
1c7dc3c to
1aab5a9
Compare
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
from
1aab5a9 to
612d94f
Compare
baloo
changed the title
rand_core from 0.6.4 to 0.9.1rand_core from 0.6.4 to 0.9.2
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
from
612d94f to
c3e9a87
Compare
Member
Author
|
I believe this is now ready to merge. |
Member
Author
|
nightly doesn't have |
Member
|
You need to update the pinned nightly version here. Could you also look into why the minimal-versions job fails? |
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
2 times, most recently
from
4e1191a to
241340f
Compare
Member
Author
|
Ha i missed the pin! thank you! I think the minimal-version was because I forgot to bump the version of |
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
from
241340f to
82d679f
Compare
Member
Author
|
tests fixed \o/ |
newpavlov
reviewed
Feb 22, 2025
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
The comments below are not relevant to this PR per se, but it could be worth to fix them while we are at it.
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
from
82d679f to
20fcb3e
Compare
baloo
commented
Feb 22, 2025
src/pss/signing_key.rs
Outdated
| { | ||
| fn sign_prehash(&self, prehash: &[u8]) -> signature::Result<Signature> { | ||
| self.sign_prehash_with_rng(&mut OsRng, prehash) | ||
| self.sign_prehash_with_rng(&mut OsRng.unwrap_err(), prehash) |
Member
Author
There was a problem hiding this comment.
Maybe something we can improve here.
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
2 times, most recently
from
84f79c1 to
e174e9f
Compare
newpavlov
approved these changes
Feb 22, 2025
Member
Author
|
huum, wait I also need to pull RustCrypto/traits#1766 |
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
from
e174e9f to
35f1ab1
Compare
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
from
35f1ab1 to
503031a
Compare
baloo
changed the title
rand_core from 0.6.4 to 0.9.2rand_core from 0.6.4 to 0.9.2; edition 2024; bump MSRV to 1.85
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
2 times, most recently
from
c0e2720 to
d4f716e
Compare
|
Seems like everything is done, Or is something missing ? |
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
from
2447167 to
7d0353a
Compare
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
5 times, most recently
from
f8d8e59 to
3172381
Compare
baloo
force-pushed
the
baloo/rand-core/0.9.0
branch
from
3172381 to
57ab112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also bumps the dependency of
signaturefrom2.3.0-pre.4to2.3.0-pre.5This pulls:
RandomMod::try_random_modandRandom::try_randommethods crypto-bigint#770Sizedrequirements on rng traits#1765Sizedrequirements on async signer traits traits#1766Fixes #466